Repository navigation
Remove Ruby code that nothing references - #13064
Merged
Merged
Conversation
This removes commands, serializers, view components, helpers and templates whose last callers went in earlier refactors, along with their tests and the locale keys only they used. The destroy-account test now checks the solution search index directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing has ever enqueued this job. Mailshots are sent from the admin pages through Mailshot::SendToAudienceSegment, which calls User::Mailshot::Send directly. This also removes the old console recipe at the top of User::Mailshot::Send, which passed a slug from before mailshots were stored in the database. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ihid-assistant
Bot
force-pushed
the
remove-unused-ruby-code
branch
from
November 18, 2026 07:01
446ae10 to
336cf44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes Ruby code that nothing in the app references any more. I checked each item by its full constant, its short name, its method name and its snake_case form across app, lib, config, db, bin, scripts, docs and test. Only its own tests referenced each one.
Removed items:
Solution::SearchCommunitySolutionsand its test.Solution::SearchViaRepresentationsreplaced it in Representation search UI #6123. The destroy-account test used it to check the solution index, so that test now reads the index document directly withget_opensearch_doc.Submission::Analysis::CancelandSubmission::Representation::Canceland their tests.ToolingJob::Cancelreplaced both in 2020.Github::Teamand its test.Github::TeamMemberreplaced it in Store github team members #3271.SerializeSubmissionsand its test. Its last caller went when the iteration block moved to React in Move iteration block in exercise page to React #552.SerializeMentorDiscussionsForStudentand its test. Its last caller went with the new solution timeline in Add a new solution timeline #6492.SerializeAuthorOrContributorsand its test. Its last caller went with the build page changes in Improve build page #6443.lib/http_authentication_token.rb, its test and itsrequirein the Rack::Attack initializer. Rack::Attack has matched the Bearer header with its own regex since 0fa9488.LayoutHelper#css_packs. Its last caller went with the Rails 7 tooling upgrade in Upgrade to Rails 7 and latest JS/CSS Tooling #2290.EmailHelper#email_button_to, which was the only method inEmailHelper. This removes the empty helper file and thehelper :emailline inApplicationMailer.ViewComponents::ConceptandViewComponents::ConceptProgressBar. Their last callers went in the 2021 journey and track page reworks.ViewComponents::Tab. Its last caller went when the journey page was unified in Unify journey page #933. The.c-tabCSS stays, because other markup uses it.ViewComponents::DonateWithCryptoand itscomponents.donate_with_cryptolocale key. Its last caller went when the crypto donation option was removed in Remove crypto donation option #7082.ViewComponents::UserActivity, itscomponents/user_activitiestemplates and their locale file. Its last caller went when the track feed was reworked in Rework the track feed #473. TheUser::Activitymodels and their STI locale files inconfig/locales/user_activities/stay.nav_dropdown_tracks_view,nav_dropdown_mentoring_viewandnav_dropdown_challenge_48in24_viewinNavSubmenus, with thecomponents.nav_submenus.viewslocale key. The nav renderslayouts/nav/<view>templates throughnav_dropdown_viewinstead.app/views/layouts/nav/challenge_48in24.html.hamland itslayouts.nav.challenge_48in24locale keys. No nav item names that view any more.SendUserMailshotJoband its test. Nothing has ever enqueued it. Mailshots go out throughMailshot::SendToAudienceSegment, which callsUser::Mailshot::Senddirectly. The old console recipe at the top ofUser::Mailshot::Sendgoes too.This also removes the entries for the deleted tests from
.github/test-timings.json.🤖 Generated with Claude Code